Content-type header works like the accept header, with support for arrays of values #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rays of values The content-type header did not support an array of header values (for example headers['Content-Type'] = ['application/json', 'text/json', 'application/xml', 'text/xml', 'application/x-www-form-urlencoded'];) it would just produce a single string (i.e. headers['Content-Type'] = 'application/json, text/json, application/xml, text/xml, application/x-www-form-urlencoded; Which is incorrect, it should be an array as Accept does. Refactored out the code from accept to a function (produceHeaderKeyValue) and changed Accept & Content-Type to use that one function.
|
@rmaclean It makes sense. Can you fix the build and maybe add a test for it? I could setup an endpoint that echos the accept headers from the request? |
|
This isn't quite right. The This can lead to error responses. For example, IIS 7.5 strips the invalid header and ASP.NET Web API 2 assumes a default of application/octet-stream and responds 415 Unsupported Media Type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content-type header did not support an array of header values (for example
headers['Content-Type'] = ['application/json', 'text/json', 'application/xml', 'text/xml', 'application/x-www-form-urlencoded'];) it would just produce a single string (i.e.headers['Content-Type'] = 'application/json, text/json, application/xml, text/xml, application/x-www-form-urlencoded;.Which is incorrect, it should be an array as Accept does. Refactored out the code from accept to a function (
produceHeaderKeyValue) and changed Accept & Content-Type headers to use that one function to generate their own header values.